Netflix
has_many relationship serialization
Hello everyone!
I recently started using fast_jsonapi in my rails API and I have to say that the performance improvement is amazing!
I just have a suggestion to make. At the moment, in order to serialise "has_many" relationships, the gem is looking for relationship_model_name_ids and queries on that. With active record serializers, it would be enough to have a method to fetch the relationship data, named after the rails convention.
e.g.
Actor has_many :movies could have a method movies and the relationship data would be serialised.
I mention this because I have some models that are Elasticsearch models and I was not storing the relationship ids, instead I had a method to fetch the relationship data ( I was caching the data as well ) and after I switched to fast_jsonapi the relationship was empty! :)
For now, I store the ids in the mode, but I think It's an easy addition for the gem, if it makes sense to you as well.
@devtoro we always look for relationship_model_name_ids(movie_ids) first as it is an optimization mechanism. It is common to just serialize only the ids unless the relationship is in the includes list. This saves unnecessary fetching of objects and object creation.
Looks like in your case you are saying if the relationship_model_name_ids(movie_ids) method doesn't exist then instead of throwing an error or skipping serialization altogether, we should fallback on the relationship_model_names(s)(movies) method to get the id.
I think this request makes sense. Do you think you can take a shot at implementing it?
