falcor icon indicating copy to clipboard operation
falcor copied to clipboard

NetflixPathEvaluator's switchProfile call implementation crashes (Javascript) Falcor client

Open mattflix opened this issue 10 years ago • 3 comments

The switchProfile @PQLEndPoint, on success, returns a PathBoundInvalidation validation for the path ['profile'].

The first that is strange here is that this path (['profile']) is not accounted for anywhere else within NetflixPathEvaluator. There is no handler for it. But, more importantly, the returned invalidation causes the Javascript Falcor client to crash in onNode() -- seemingly while trying to process the returned PathBoundInvalidation for ['profile']. Specifically, within the onNode() function, the "node" variable ends up undefined, which seems to be an unexpected condition, as it is accessed unconditionally.

I imagine that this crash perhaps has something to do with the fact that it is extremely likely for nothing to be located at path ['profile'] in the client's cache (see above point about no handler for ['profile']).

mattflix avatar Oct 13 '15 00:10 mattflix

@sdesai did this ever get resolved?

ThePrimeagen avatar Dec 04 '15 15:12 ThePrimeagen

[edited] Not explicitly, but we fixed issues around calls() which only return invalidations (and no path values) which may have been the root cause.

sdesai avatar Dec 04 '15 17:12 sdesai

@sdesai Follow-up with Windows 10 to see if their problem is fixed.

ktrott avatar Mar 28 '16 20:03 ktrott