dynomite consider supporting SELECT 0 as noop

anything other than 0 ( default ) should return error, but it will help to support "stupid" redis clients that tend to do "SELECT 0" even for default connection.

May 18 '19 03:05 maksimlikharev

@maksimlikharev Good point. Would you like to submit a patch that does the above?

May 29 '19 04:05 smukil

sure, we can do it, not immediately but in short reasonable future, dev branch?

May 29 '19 17:05 maksimlikharev

PR created: https://github.com/Netflix/dynomite/pull/670

unfortunately, PR build failed: redis.exceptions.ResponseError: hash value is not an integer

this error seems preexisted as previous PR failed on the same line.

Jun 04 '19 20:06 maksimlikharev

@maksimlikharev - Are you still working on it? Do you mind if I take over this patch, if you are not actively working on it?

Oct 10 '19 23:10 anujphadke

we created pr for this, but we running dyno from our fork, so I'll confirm on Monday if we done anything more to that.

Oct 12 '19 02:10 maksimlikharev

we've done different code for v5.9 because of the changes in Info command, this is what we going to deploy in our environment. please check PRs in out fork: 3,4,5 https://github.com/ThomsonReuters-IPS/dynomite/pulls?q=is%3Apr+is%3Aclosed

Oct 14 '19 18:10 maksimlikharev