dgs-framework icon indicating copy to clipboard operation
dgs-framework copied to clipboard

bug: DGS metrics stop reporting Spring Boot 2.6.10, micrometer-core 1.88

Open deweyjose opened this issue 3 years ago • 2 comments

Hi team,

We have projects that have upgrade to Spring Boot 2.6.10 and have seemingly lost all of the DGS loader, fetcher and query metrics.

It looks like we're at micrometer-core 1.8.8 now. Should this version of spring-boot/micrometer be compatible with graphql-dgs-spring-boot-micrometer ?

Thanks in advance, let me know if you need any more information.

deweyjose avatar Sep 30 '22 00:09 deweyjose

Hi there, it looks like the issue was related to how metrics were pushed. They moved from Histograms to Distributions. Closing this :)

deweyjose avatar Sep 30 '22 14:09 deweyjose

Actually - going to reopen this. We have the following configured in our application.yaml configuration:

    dgs-graphql:
      autotime:
        percentiles: [ 0.50,0.75,0.90,0.95,0.99 ]
        percentiles-histogram: true

micrometer is pushing Distributions instead.

deweyjose avatar Sep 30 '22 14:09 deweyjose

Is there any update on this issue? I'm also suffering from lack of DGS due to updating to DGS 5.1.16. Can you point me to what users of DGS need to update in our application configuration or code to get the metrics back?

@deweyjose @paulbakker

glacier avatar Feb 20 '23 19:02 glacier

The property was broken in 21e625a. I'll open a PR to fix it.

kilink avatar Jan 23 '24 19:01 kilink