conductor icon indicating copy to clipboard operation
conductor copied to clipboard

AsyncComplete event task publishing event multiple times.

Open manan164 opened this issue 3 years ago • 1 comments

Revert event task-related changes from the PR "Split event system task implementation between start and execute (#3187)"

Pull Request type

  • [X] Bugfix

Changes in this PR

Describe the new behavior from this PR, and why it's needed Issue # Reverting the PR #3187

Alternatives considered

  1. We can put a condition check so that EVENT task execute method will be called once but that will be kind of not proper fix.

Describe alternative implementation you have considered

manan164 avatar Nov 02 '22 09:11 manan164

@manan164 To guarantee consistency of event task execution, the splitting of validation and publishing is necessary. By reverting the change, we will run into the race conditions again. We believe it will be best to make the event task an async system task and let this be handled by the AsyncSystemTaskExecutor.

apanicker-nflx avatar Dec 05 '22 22:12 apanicker-nflx

This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 7 days.

github-actions[bot] avatar Jan 20 '23 00:01 github-actions[bot]

This PR was closed, because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Jan 27 '23 00:01 github-actions[bot]