conductor icon indicating copy to clipboard operation
conductor copied to clipboard

Task not retried after second attempt when failing task through event queue

Open pmchung opened this issue 3 years ago • 1 comments

Task is not retried after first attempt when a retry is triggered from event queue when using workflowId and taskRefName.

https://github.com/Netflix/conductor/blob/9e80c4af02c504072dfc775fb97430907bc1097c/core/src/main/java/com/netflix/conductor/core/events/SimpleActionProcessor.java#L130-L146

With multiple created task under a taskRefName due to multiple retry attempts, workflow.getTaskByRefName will get the last created task for the ref name.

I believe the change here https://github.com/Netflix/conductor/pull/2883 introduced some sorting that now selects the first created task which would already be previously failed

pmchung avatar Oct 20 '22 20:10 pmchung

Hi @pmchung , Thanks for reporting. I want to understand the exact issue here. Can you please explain in detail? As per my understanding even when the task is retried the taskRefName won't get changed. However, I do see the behavioral change before and after (https://github.com/Netflix/conductor/pull/2883) so raising a draft (https://github.com/Netflix/conductor/pull/3338) to correct it.

manan164 avatar Nov 09 '22 18:11 manan164