conductor icon indicating copy to clipboard operation
conductor copied to clipboard

[FEATURE]: Rename EXCLUSIVE_JOIN to a more intuitive name

Open aravindanr opened this issue 4 years ago • 7 comments

Please read our contributor guide before creating an issue.
Also consider discussing your idea on the discussion forum first.

Describe the Feature Request

The name EXCLUSIVE_JOIN does not do justice to the work that this task does. EXCLUSIVE_JOIN sounds like a specialized version of JOIN, when in fact the two tasks are not related.

JOIN : Join task is used to wait for completion of one or more tasks spawned by fork tasks. EXCLUSIVE_JOIN: Exclusive Join task helps capture Task output from Switch Task's flow.

Describe Preferred Solution

Rename the EXCLUSIVE_JOIN task to SELECT , while maintaining backwards compatibility with workflows using EXCLUSIVE_JOIN.

Describe Alternatives

N/A

aravindanr avatar Feb 07 '22 23:02 aravindanr

#2758 As I was confused by this. It maybe a good idea to have some examples with the each system task of the use cases that show images of the workflow. Current state: image I could put together some prs for improving the docs

ZergRushJoe avatar Feb 08 '22 13:02 ZergRushJoe

@ZergRushJoe Please do. Appreciate the help. the docs need some love.

aravindanr avatar Feb 08 '22 19:02 aravindanr

@aravindanr When I introduced this System Task, I have reviewed several names and felt that Exclusive_Join makes better sense wrt the way the exclusive output is produced to the join.

I will prepare some examples and better documentation soon.

jkaipa avatar Mar 24 '22 15:03 jkaipa

Where can i find the docs about the EXCLUSIVE_JOIN? Anyone help?thanks.

jxfw avatar Aug 03 '22 06:08 jxfw

@jxfw The documentation for the EXCLUSIVE_JOIN was missed during the transfer to the new website, we will update this soon. Thanks for reporting.

apanicker-nflx avatar Aug 08 '22 17:08 apanicker-nflx

@apanicker-nflx I will prepare some examples with usage instructions for this system task in next week or two. Its a long time due.

jkaipa avatar Aug 08 '22 22:08 jkaipa

Thank you @jkaipa , we will add this to the conductor docs site.

apanicker-nflx avatar Aug 15 '22 21:08 apanicker-nflx