Maikel van Dort

Results 80 comments of Maikel van Dort

@adammccullagh I would suggest using `req.originalUrl`. e.g. `/_next/static/css/app/layout.css` resolved into `/_next/static` if it's checks on the path: `/_next/:slug`

> The legacy behaviour is on L30: > > [http-proxy-middleware/src/http-proxy-middleware.ts](https://github.com/chimurai/http-proxy-middleware/blob/897611af512ffaf6add1601585952356fde8aec5/src/http-proxy-middleware.ts#L124-L131) > > Lines 124 to 131 in [897611a](/chimurai/http-proxy-middleware/commit/897611af512ffaf6add1601585952356fde8aec5) > > /** > * Incorrect usage confirmed: https://github.com/expressjs/express/issues/4854#issuecomment-1066171160 > * Temporary...

Vite seems to have switched to [http-proxy-3](https://github.com/sagemathinc/http-proxy-3), see [here](https://github.com/vitejs/vite/pull/20402). Might be worth to switch too?

Facing the same issue, while I specifically add a fallback text when the component alt prop is empty or nullish; [Playground](https://biomejs.dev/playground/?code=aQBtAHAAbwByAHQAIAB0AHkAcABlACAAewAgAEMAbwBtAHAAbwBuAGUAbgB0AFAAcgBvAHAAcwAsACAARgBDACAAfQAgAGYAcgBvAG0AIAAnAHIAZQBhAGMAdAAnADsACgAKAHQAeQBwAGUAIABDAGEAcgBkAEkAbQBhAGcAZQBQAHIAbwBwAHMAIAA9ACAAQwBvAG0AcABvAG4AZQBuAHQAUAByAG8AcABzADwAJwBpAG0AZwAnAD4AOwAKAAoAZQB4AHAAbwByAHQAIABjAG8AbgBzAHQAIABDAGEAcgBkAEkAbQBhAGcAZQA6ACAARgBDADwAQwBhAHIAZABJAG0AYQBnAGUAUAByAG8AcABzAD4AIAA9ACAAKAB7AAoAIAAgACAAIABhAGwAdAAgAD0AIAAnAHQAaABpAHMAIABpAHMAIABhACAAYwBvAG8AbAAgAGkAbQBhAGcAZQAnACwACgAgACAAIAAgAC4ALgAuAHIAZQBzAHQAUAByAG8AcABzAAoAfQApACAAPQA%2BACAAewAKACAAIAAgACAAcgBlAHQAdQByAG4AIAAoAAoAIAAgACAAIAAgACAAIAAgACAAIAA8AGkAbQBnAAoAIAAgACAAIAAgACAAIAAgACAAIAAgACAAIAAgAHMAcgBjAD0AIgAvAHQAZQBzAHQALgBwAG4AZwAiAAoAIAAgACAAIAAgACAAIAAgACAAIAAgACAAIAAgAGEAbAB0AD0AewBhAGwAdAB9AAoAIAAgACAAIAAgACAAIAAgACAAIAAgACAAIAAgAHsALgAuAC4AcgBlAHMAdABQAHIAbwBwAHMAfQAKACAAIAAgACAAIAAgACAAIAAgACAALwA%2BAAoAIAAgACAAIAApADsACgB9ADsA)

> @gkiely @Netail Is there a reason why you put the spread after setting the `alt` and `src` attributes? > > We could improve the diagnostic saying that this should...

> Ok I see. I think we can simply check if `alt` exists and ignore the spread. This looks fair to me. That would be lovely, maybe nice to reopen...

> How about [Hono Proxy Helper](https://hono.dev/docs/helpers/proxy#proxy)? I have not tried yet but Hono is nice framework. For us the hono proxy wasn't an option as it does not support websocket

Important parts in the repro; `package.json` (versions defined) https://github.com/Netail/repro-yarn-lock/blob/main/apps/web/package.json#L5-L8 `yarn.lock` (how the yarn.lock entries also should look like after being pruned) https://github.com/Netail/repro-yarn-lock/blob/main/yarn.lock#L25-L41 Currently blocking us from optimally using prune in...

The same for the`yarn:`, `github:`, `git` protocols. (And `file:`, `portal:` & `link:`, but those are not even copied over, related to: https://github.com/vercel/turborepo/issues/4105). Basically all version fields starting with a protocol...

@chris-olszewski are you able to help me with this issue? yarn.lock entries with a protocol shouldn't be merged together (neither with one without a protocol) Probably something with; https://github.com/vercel/turborepo/blob/6d4e655b0120c96e20308adbf46380e5b71a7db1/crates/turborepo-lockfiles/src/yarn1/mod.rs#L148-L155 Where...