trident
trident copied to clipboard
Add --kubeconfig option to tridentctl
Change description
This PR will add an optional --kubeconfig argument to specify a kubeconfig file to use, similar to kubectl and oc.
Project tracking
see https://github.com/NetApp/trident/issues/734)
Do any added TODOs have an issue in the backlog?
N/A
Did you add unit tests? Why not?
No, this only adds one optional argument that is no-op when not specified
Does this code need functional testing?
The changes do not change the main logic of the tridentctl code. I have tested it using different commands and kubeconfig files and it is working.
Is a code review walkthrough needed? why or why not?
Probably not needed as the changes are relatively simple and only touch a few files
Should additional test coverage be executed in addition to pre-merge?
May require adding test that pass a specific kubeconfig file
Does this code need a note in the changelog?
Yes - same as title of this PR
Does this code require documentation changes?
Yes - self descript line to be added is sufficient as users are already familiar with the argument from using kubectl and oc