trident icon indicating copy to clipboard operation
trident copied to clipboard

Modifying SG parameters

Open jsuarezs opened this issue 4 years ago • 4 comments

Hello team.

I'm requesting these changes as our customers are getting confusing.

For the StorageClasses: We're not using anymore the provisioner "netapp.io/trident" and needs to be replaced by "csi.trident.netapp.io" in all of them. For the CVS backend configuration doesn't make sense to have the parameter "limitVolumeSize": "50Gi" since the minimum volume size is 100Gi so using that they will get the error that the size requested is bigger than the one set here.

Pull request: #620.

I really appreciate you take care of this. Thanks a lot !

jsuarezs avatar Aug 27 '21 07:08 jsuarezs

@jsuarezs thank you for bringing this to our attention. Can you sign the CCLA agreement so we can accept your PR? Thanks!

balaramesh avatar Aug 30 '21 14:08 balaramesh

Good morning Bala.

I’ve already signed and sent it following the instructions in the document.

Let me know, Javi.

Gracias, un saludo.

El 30 ago 2021, a las 16:38, Bala Ramesh @.***> escribió:

 @jsuarezs thank you for bringing this to our attention. Can you sign the CCLA agreement so we can accept your PR? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

jsuarezs avatar Aug 31 '21 07:08 jsuarezs

@jsuarezs I noticed that your PR was targeting stable/v21.04. I wanted to offer some context as to why the examples/docs still point to netapp.io/trident in the docs for 21.04 and releases prior. v21.04 supports Kubernetes versions 1.11 and onwards. For Kubernetes versions <1.14, Trident can be configured to run as a traditional, non-CSI storage provisioned (where the provisioner is set to netapp.io/trident). It can also be installed on Kubernetes versions 1.14 and above, where it will run as a CSI provisioner (which needs provisioner to be set to either netapp.io/trident or csi.trident.netapp.io). The important thing to note here is that Trident will also automatically handle storageClasses with netapp.io/trident, and update them to use csi.trident.netapp.io.

I agree that limitVolumeSize can be removed from the examples

balaramesh avatar Sep 01 '21 16:09 balaramesh

Hello Bala.

Thanks a lot for the explanation that's really useful and I think we could include it the docs but anyway I agree on that. Regarding the limitVolumeSize parameter is something we could remove (I did another commit just in case).

Thanks a lot.

jsuarezs avatar Sep 02 '21 08:09 jsuarezs