NetApp
feat(helm): add registry value for trident and autosupport
Change description
This allows to overwrite registries for the trident and autosupport images. It mainly covers the case where eg. the trident image is built in house with a wrapper but versioning is the same as given by the chart. When we just have to overwrite the registry it's still compatible with dependency management like renovate.
Project tracking
None
Do any added TODOs have an issue in the backlog?
No
Did you add unit tests? Why not?
No, trivial change
Does this code need functional testing?
Doubt it
Is a code review walkthrough needed? why or why not?
Doubt it
Should additional test coverage be executed in addition to pre-merge?
No
Does this code need a note in the changelog?
Doubt it
Does this code require documentation changes?
No
Additional Information
Hi @oliverbaehler our tridentImage and tridentAutosupportImage fields allow you to put the whole registry path and tag. The imageRegistry field allows you to input the registry used for all Trident images (trident, tridentOperator, tridentAutosupport) and assumes this registry would be used for all the images mentioned. Is this sufficient for your use case?
No, the registry is exclusive for the trident iamge on our case. Let's consider the case with the latest version.
Renovate patches the new version (Application Release 25.06.0):
Now we are just patching the trident image (for talos nfs support). On that image repository we also have renovate running, which release the version 25.06.0 but in the private registry.
So as you can see with the proposed change, the tag would not have to be part of the entire image override and i could use the appversion used from the chart. Therefor allowing me to just merge the above. In the current setup i know also have to manually bump the image tag to 25.06.0 in the values
I know it might be a nice thing, but would greatly help in that scenario.
Have you completed the necessary steps outlined in the CONTRIBUTING.md file? Including the signed CCLA?
Sign and submit NetApp's Contributor License Agreement. You must sign and submit the Corporate Contributor License Agreement (CCLA) in order to contribute.