Neo-Store icon indicating copy to clipboard operation
Neo-Store copied to clipboard

minsdk requirement set too high in Theme preferences

Open orency opened this issue 1 year ago • 2 comments

https://github.com/NeoApplications/Neo-Store/blob/90ce6fedda81eaafa160d52212825083b563f5cc/src/main/kotlin/com/machiav3lli/fdroid/content/PrefsMetaData.kt#L107-L110

Actually android support dark mode since 4.1 .However ,switch been added in AOSP system settings and tile not untill android 10. So many third party apps can do this switch without root bellow api 29,such as Darktheme night-mode-tile Dark-Mode-Switch Considered neo-store 's minsdk has setted to 23 and would be 24 in 1.0 version, i suggest delete this judgement that users bellow api 29 with these little tools can also switch theme follow system. We can guess the amount of users have this need from the downloads of this tool.


https://github.com/NeoApplications/Neo-Store/blob/90ce6fedda81eaafa160d52212825083b563f5cc/src/main/kotlin/com/machiav3lli/fdroid/content/PrefsMetaData.kt#L111-L116 Actually android support pick color from wallpaper since api 27,android 12 just give it a default implement. https://developer.android.com/reference/android/app/WallpaperColors So we can also lower this minsdk requirement to at least 28.


Google always do these thing that implement a function in early,but test and hide it for years .Then introduce it as a new feature officially after years to attract people's eyes.😀

orency avatar Mar 02 '24 13:03 orency

I'm already aware of these facts, but can't see the value of investing such effort in half-baked, hacky implementations to backport such secondaries or in supporting android versions, that are as good as dead.

That said, maintainable code contributions are still welcome.

machiav3lli avatar Mar 11 '24 23:03 machiav3lli

About supporting follow night mode on low version android,we don't need to do anything about hacky backport .just delete the 'if' judgement and put the action on the above,then everything else will work ok.

orency avatar Mar 28 '24 17:03 orency