Neo-Backup icon indicating copy to clipboard operation
Neo-Backup copied to clipboard

[Bug] crash after attempting to disable a non-disable package

Open unquote7083 opened this issue 1 year ago • 0 comments

Guidelines

  • [X] I have read the FAQ and it doesn't cover the issue.
  • [X] I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • [X] I'm on the latest version.
  • [X] I'm not using a test build (alpha/beta/release-candidate).
  • [X] This issue contains only one bug.

Describe the bug

  1. attempt to disable a non-disable package
  2. watch app crash

Expected Behavior

No crash

Neo Backup's Version

8.3.8

Installation Source

Official F-Droid repo

Last Known Working Version

No response

Relevant information

  • Android Version: 13

Logcat:

D NeoBackup>ShellHandler$Companion:81::runAsRoot: Command(s) pm disable --user 0 com.package.name ended with 1
--------- beginning of crash
E AndroidRuntime: FATAL EXCEPTION: main
E AndroidRuntime: Process: com.machiav3lli.backup, PID: 13994
E AndroidRuntime: com.machiav3lli.backup.handler.ShellCommands$ShellActionFailedException: Could not disable package com.package.name
E AndroidRuntime: 	at com.machiav3lli.backup.handler.LogsHandler.enableDisable(Unknown Source:99)
E AndroidRuntime: 	at com.machiav3lli.backup.viewmodels.AppSheetViewModel$enableDisable$2.invokeSuspend(Unknown Source:25)
E AndroidRuntime: 	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:8)
E AndroidRuntime: 	at kotlinx.coroutines.DispatchedTask.run(Unknown Source:114)
E AndroidRuntime: 	at androidx.work.Worker$2.run(Unknown Source:10)
E AndroidRuntime: 	at kotlinx.coroutines.scheduling.TaskImpl.run(Unknown Source:2)
E AndroidRuntime: 	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(Unknown Source:95)
E AndroidRuntime: 	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [DeferredCoroutine{Cancelling}@cd2edf8, Dispatchers.Main.immediate]
E AndroidRuntime: Caused by: com.machiav3lli.backup.handler.ShellHandler$ShellCommandFailedException
E AndroidRuntime: 	at com.machiav3lli.backup.handler.ShellHandler$Companion.runAsRoot(Unknown Source:100)
E AndroidRuntime: 	at com.machiav3lli.backup.handler.LogsHandler.enableDisable(Unknown Source:74)
E AndroidRuntime: 	... 6 more

And when trying to disable manually returns the exit code 1 and a message: Failure: package is non-disable

unquote7083 avatar Dec 08 '24 04:12 unquote7083