Neo-Backup icon indicating copy to clipboard operation
Neo-Backup copied to clipboard

Tutorial/Instruction request (data parts selector for Backup/Restore)

Open LucasBS1 opened this issue 1 year ago • 8 comments

It's not a bug, but since there is no adequate category...

Very simple, actually:

I made a list of apps using the PUT function.

How do I backup ONLY THE DATA of these apps ?

Right now, I have to backup everything and the delete the .apks

LucasBS1 avatar Sep 26 '24 12:09 LucasBS1

It's still not possible.

@hg42 I guess this is a FR for your implementation.

machiav3lli avatar Sep 28 '24 12:09 machiav3lli

Thank you for addressing this

LucasBS1 avatar Sep 28 '24 15:09 LucasBS1

@hg42 I guess this is a FR for your implementation.

yes, it's already somewhere in my head...

I was basically waiting, that I can reuse the dialog from the other parts... as far as I remember, it wasn't a Composable, yet, not sure if I revisited it later

hg42 avatar Oct 04 '24 22:10 hg42

yeah, the "openDialogCustom" inflation...

It's not the recommended way. It's recommended to do this with callbacks.

  1. because the Composable must know something about the calling site
  2. it's an output parameter, while Compose is a functional paradigm, so there are no output parameters, even if Kotlin allows it, it's not matching the design (and this could create multithreading problems)

Btw. it's kind of undefined if it's better to use onAction (or similar) and distinguish the cases in the callback (onActions("save", ...) vs. onAction("cancel", ...), or to provide a callback for each situation (e.g. onSave(...) vs. onCancel(...)). I am not sure, which would be better, but I would want to have the same way in all occasions.

I postponed the use of the dialog until this is fixed somehow, because each usage would make it more work to change it.

Would you accept, if I would rewrite the openDialogCustom thingy to use callbacks? it's distributed all over the source, so there should nothing be going on in parallel.

Though, I don't know when I have spare time to do such a job.

hg42 avatar Oct 05 '24 19:10 hg42

there's more to it...

we have different selections:

apk / data / both apk / data / dedata / ext / obb / media no_backup cache

I think these should all have the same selection: apk / data / dedata / ext / obb / media / no_backup / cache

Backup page is apk / data basically because with user apps you want apk, but with system apps you don't. For really individual batches you would want all switches. So either you have all switches on each entry, or you do the selection group wise, which is more convenient.

Such a dialog does not exist, so I guess I need to create my own. However, this is not sufficient, because no_backup and cache are global options.

hg42 avatar Oct 07 '24 18:10 hg42

added, try pumpkin test apk:

https://t.me/neo_backup/53944/59674

it's independent of the other selectors, because it's more consistent this way, was easy enough to implement. The others also have different circumstances, so they would not fit anyways.

hg42 avatar Oct 08 '24 20:10 hg42

will probably be added to next release

hg42 avatar Oct 08 '24 20:10 hg42

I was basically waiting, that I can reuse the dialog from the other parts... as far as I remember, it wasn't a Composable, yet, not sure if I revisited it later

All dialogs are composables since a while (if I'm not mixing projects).

Would you accept, if I would rewrite the openDialogCustom thingy to use callbacks? it's distributed all over the source, so there should nothing be going on in parallel.

You can surely test alternatives, but am not sure if it'll replace current components.

I think these should all have the same selection: apk / data / dedata / ext / obb / media / no_backup / cache

Not really, all but no_backup & cache are REAL polytomic types, while these two are kinda specific file types acrross these types. Therefore a better differentiation should take place.

machiav3lli avatar Oct 09 '24 22:10 machiav3lli