Alex
Alex
> @NeffIsBack ironic that the thing I merge would have found the errors running e2e tests 😂 Should I test this PR or #729? Definitely has its irony😂 That was...
> @NeffIsBack and @Marshall-Hallenbeck sorry for the breaking changes I should have double-checked the other places where the spider function was called. No worries about that. In the end it...
I am still not fully convinced. Why changing the existing structure of initializing of creating the object and then spider the share when we can just leave it as is?...
> > > i really dont remember which iscsi python package i tried. for iscsi connection i always use open-iscsi package. maybe it can be used instead native python package....
Probably a less terrifying module name😅
> but netexec uses another impacket, https://github.com/Pennyw0rth/impacket, when the pr that I made from impacket gets merged to the impacket that netexec use, then I can make the changes and...
Done, our impacket should be up-to-date now
Thanks for the PR! Gonna take a look into it when i have the time
> Solved a merge conflict Replaced `mapping_enum_group.add_argument("--shares", type=str, nargs="?", const="", help="Enumerate shares and access, filter on specified argument…")` with `mapping_enum_group.add_argument("--shares", action="store_true", help="Enumerate shares and access") ` Looks like you did...
Thanks for the PR! Looks cool.