Jay Herron

Results 65 comments of Jay Herron

Hey @itayAmza, I don't think there's a good way to call `validate(_ decoder: Decoder)` before `decode`, since fields automatically define the decode block here: https://github.com/GraphQLSwift/Graphiti/blob/af903a243862c6427935677b91f67df0c21f2a71/Sources/Graphiti/Field/Field/Field.swift#L55 I think you have a...

This was resolved for Map and GraphQLResult in the linked merge request. However, when encoding with an ordinary `JSONEncoder`, order is not preserved due to the internals of `JSONEncoder`.

This was actually fixed in https://github.com/GraphQLSwift/GraphQL/pull/94 by providing a `GraphQLJSONEncoder` that preserves result ordering.

> welcome a bit of bikeshedding on the matter I think `multiValues(_:)` is a fine name. Along the same vein, `allValues` seems like a reasonable option. However, I think I...

Sure, I can provide a little insight. I did build my final app using the normal Vapor websocket implementation, but I didn't use this package - just Graphiti. In terms...

No problem! > So, is there a single, shared, singleton-like publisher for your whole app No, we create a fresh [PublishSubject](http://reactivex.io/documentation/subject.html) in each GraphQL subscription resolver. This is because we...

@kumararvind I believe this issue has been fixed by https://github.com/GraphQLSwift/GraphQL/pull/133. Could you verify?

Oof, yeah this is a tough one. @alexsteinerde, you're right - the crux of the issue is [TypeProvider.swift L53](https://github.com/GraphQLSwift/Graphiti/blob/main/Sources/Graphiti/Definition/TypeProvider.swift#L53), where we map a Graphiti `TypeReference` to a GraphQL `GraphQLTypeReference` using...

I can confirm that this is also an issue when using Optional types (not only TypeReferences). For example, the following code fails on the optional `LocationObject?` because it was aliased...