Tap to retry stop working when failureImageUri is loaded

[vahidvdn]

Hey all. First placeholderImageUri is loaded, then if there is no network connection we can tap to placeholder multiple times. If still no network connection, then failureImageUri appears. After that we can not tap to retry.

Any idea?

[VladimirAmiorkov]

Hi @vahidvdn ,

Thank you for bringing this to my attention. I researched it and it looks like this is a built-in functionality in the native Fresco library that is used by the plugin. When the tapToRetryEnabled is set to true by design the nubmer of possible retries is 4 as mentioned here, after that the retry functionality is disabled. I looked around and there is a possible solution to this by extending the native PipelineDraweeController used it as native controller in the plugin here and overriding its setRetryManager method and pass an extended version of an RetryManager which has its setMaxTapToRetryAttemps changed from the default 4. This will require a lot of changes to the nativescript-fresco plugin and is not patchable in a minor version.

I am parking this as a feature request also if anyone is up to the task of providing this functionality we are aways welcoming new PRs and contributions.

[vahidvdn]

@VladimirAmiorkov Thanks for the quick reply. I understand what the matter is. I think the best functionality of tapToRetry is which instagram implemented.

And about your solution, I think increasing max tap to retry functionality isn't the answer. Because failureImageUri appears after maxTapToRetryAttemps . Btw, thank you.