nativescript-camera icon indicating copy to clipboard operation
nativescript-camera copied to clipboard
verified publisher icon NativeScript

docs(README): add note for Android 10 permissions.

Open tralves opened this issue 5 years ago • 3 comments

PR Checklist

  • [X] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
  • [X] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
  • [X] All existing tests are passing
  • [X] Tests for the changes are included

Right now, this plugin will not work on Android API 29 or greater. In Issue #245, @NathanaelA provided the solution, but I (as well as the issue's OP) think it should be more visible in the README.

Closes #245.

tralves avatar Aug 06 '20 14:08 tralves

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @tralves. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot[bot] avatar Aug 06 '20 14:08 cla-bot[bot]

@cla-bot check

tralves avatar Aug 06 '20 15:08 tralves

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Aug 06 '20 15:08 cla-bot[bot]