Update for remote tags which have 'refs/tags/' in front of the tag name

Open joepjoosten opened this issue 7 years ago • 4 comments

When using this in with continuous integration, the cloned git repo only had the tags from the remote repo, and when doing a git describe, the tags contain 'refs/tags/' in front of the tag name. This change to the regex fixes this.

Apr 12 '18 08:04 joepjoosten

Hi @joepjoosten, thank you for your contribution, it looks great!

There's just this one little minor thing before we can merge it.

Apr 13 '18 07:04 deepy

Hi @deepy. Fix the duplicate test that i wrongfully copy / pasted....

Apr 17 '18 09:04 joepjoosten

@deepy and now it also returns the version without "refs/tags" so that version can be used correctly

Apr 17 '18 09:04 joepjoosten

Fantastic :-)

Have you signed the CLA? https://www.cinnober.com/cla

Apr 18 '18 07:04 deepy