An error in calculating MAPE for QoR tasks

Open Jedges opened this issue 1 year ago • 2 comments

/models/qor/SynthNetV1/utils.py line 258，When calling mean_absolute_percentage_error for calculation, are the two parameters placed in reverse order? The first one in the function description is y_true, and the second one is y_pred, but the code uses y_pre as the first parameter. I am not sure if my understanding is wrong, please let me know if I am wrong

Aug 14 '24 07:08 Jedges

Indeed, you pointed out an error. I did calculate the MAPE score incorrectly. It should have been reversed.

Can you make a PR with the change?

Aug 15 '24 05:08 animeshbchowdhury

Yes, I maked a PR with the change. But I'm not sure if I'm doing the PR operation correctly, this is my first time using it.

Aug 15 '24 06:08 Jedges