cutlass icon indicating copy to clipboard operation
cutlass copied to clipboard

Add `infinity` to `cutlass::platform::numeric_limits<half_t>`

Open eqy opened this issue 1 year ago • 3 comments

Fix for PyTorch build

CC @ptrblck @nWEIdia

eqy avatar Jul 22 '24 19:07 eqy

This is the last thing blocking the torch upgrade @eqy , @thakkarV @nWEIdia @ptrblck could we get this merged?https://github.com/pytorch/pytorch/pull/131493

Skylion007 avatar Aug 09 '24 16:08 Skylion007

@hwu36 pointed out that what this PR adds already exists here: https://github.com/NVIDIA/cutlass/blob/main/include/cutlass/half.h#L588

thakkarV avatar Aug 09 '24 21:08 thakkarV

That seems gated by, __CUDACC_RTC__, is that potentially an issue?

eqy avatar Aug 09 '24 22:08 eqy

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Sep 08 '24 23:09 github-actions[bot]

This change has been added in cutlass/half.h. This PR can be closed @hwu36

Junkai-Wu avatar Nov 01 '24 02:11 Junkai-Wu