cuda-quantum icon indicating copy to clipboard operation
cuda-quantum copied to clipboard

Enable custom unitary operations in C++ library mode

Open amccaskey opened this issue 1 year ago • 1 comments

TODO add some tests for custom unitaries

amccaskey avatar May 23 '24 00:05 amccaskey

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar May 23 '24 00:05 copy-pr-bot[bot]

Are we going to punt on using concepts in the headers then?

schweitzpgi avatar May 23 '24 13:05 schweitzpgi

/ok to test

Command Bot: Processing...

amccaskey avatar May 23 '24 16:05 amccaskey

/ok to test

Command Bot: Processing...

amccaskey avatar May 23 '24 18:05 amccaskey

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions[bot] avatar May 23 '24 18:05 github-actions[bot]

These changes are looking good. I will leave it to Eric / Thien for final approval. I think it is still missing the override of getQubitOrdering method by the tenornet simulators since they follow the same convention as qpp (MSB). Got the following two failures as of commit 0efb23bcd97e992b4d770fb94f7f878fb63621fa

The following tests FAILED:
        389 - tensornet_CustomUnitaryTester.checkSimple (Failed)
        473 - tensornet_mps_CustomUnitaryTester.checkSimple (Failed)

khalatepradnya avatar May 28 '24 16:05 khalatepradnya

/ok to test

Command Bot: Processing...

amccaskey avatar Jun 01 '24 14:06 amccaskey

/ok to test

Command Bot: Processing...

amccaskey avatar Jun 03 '24 17:06 amccaskey

/ok to test

Command Bot: Processing...

amccaskey avatar Jun 04 '24 12:06 amccaskey

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions[bot] avatar Jun 04 '24 14:06 github-actions[bot]

/ok to test

Command Bot: Processing...

khalatepradnya avatar Jun 07 '24 16:06 khalatepradnya

/ok to test

Command Bot: Processing...

khalatepradnya avatar Jun 07 '24 16:06 khalatepradnya

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions[bot] avatar Jun 07 '24 18:06 github-actions[bot]

/ok to test

Command Bot: Processing...

khalatepradnya avatar Jun 07 '24 21:06 khalatepradnya