cuda-python icon indicating copy to clipboard operation
cuda-python copied to clipboard

Ensure `cuda` is a namespace package & Improve warnings

Open leofang opened this issue 10 months ago • 6 comments

Close #477. Close #162.

leofang avatar Mar 06 '25 03:03 leofang

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Mar 06 '25 03:03 copy-pr-bot[bot]

/ok to test

leofang avatar Mar 06 '25 03:03 leofang

Doc Preview CI :---: |

:rocket: View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-493/
|
https://nvidia.github.io/cuda-python/pr-preview/pr-493/cuda-core/
|
https://nvidia.github.io/cuda-python/pr-preview/pr-493/cuda-bindings/

|

Preview will be ready when the GitHub Pages deployment is complete.

github-actions[bot] avatar Mar 06 '25 03:03 github-actions[bot]

/ok to test

leofang avatar Apr 04 '25 23:04 leofang

what exactly was the reason for adding these files? How much trouble is it to leave some hints in the PR description?

As part of the epic #493, we need to remove cuda/__init__.py to ensure cuda is a namespace package. The existence of this file has been a source of multiple traps and bugs.

We still kept it around because it used to provide cuda.__version__. Since we have raised a deprecation warning for a few releases, and it is a minor thing, we now remove it entirely.

leofang avatar Apr 04 '25 23:04 leofang

This is ready for review. I was hoping to address https://github.com/NVIDIA/cuda-python/pull/517#discussion_r2009201045, but it seems the original issue (leading to our weird MANIFEST.in) still persists.

leofang avatar Apr 07 '25 22:04 leofang

/ok to test

leofang avatar Apr 18 '25 04:04 leofang

/ok to test

@leofang, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

copy-pr-bot[bot] avatar Apr 18 '25 04:04 copy-pr-bot[bot]

/ok to test 88144ee

leofang avatar Apr 18 '25 04:04 leofang

Doc Preview CI :---: Preview removed because the pull request was closed or merged.

github-actions[bot] avatar Apr 21 '25 16:04 github-actions[bot]