TransformerEngine icon indicating copy to clipboard operation
TransformerEngine copied to clipboard

make grouplinear accept the fp8 input

Open Autumn1998 opened this issue 10 months ago • 1 comments

Description

Make the Grouped linear accept the blockwise fp8 input

Rely on https://github.com/NVIDIA/TransformerEngine/pull/1707 for the compact scaling factors.

TODO:

  • [ ] Change the kernel to use compact scaling factors.
  • [ ] Test

Type of change

  • [ ] Documentation change (change only to the documentation, either a fix or a new content)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Infra/Build change
  • [ ] Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • [ ] I have read and followed the contributing guidelines
  • [ ] The functionality is complete
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

Autumn1998 avatar Apr 21 '25 11:04 Autumn1998

Please take a look this https://github.com/NVIDIA/TransformerEngine/pull/1707

FP8 gather for dense model + sequence parallel should be supported with the new need_compact usage API. Suggestions are highly welcomed!

zhongbozhu avatar Apr 26 '25 01:04 zhongbozhu