[https://nvbugs/5685015][fix] Update invalid max_token test

[JunyiXu-nv]

Summary by CodeRabbit

• Tests
  • Updated validation tests for max_tokens parameter error messages to reflect refined error messaging that provides clearer guidance when invalid values are provided.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Test Coverage

• examples/serve/test_serve_negative.py::test_invalid_max_tokens

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• [x] Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[JunyiXu-nv]

/bot run

[coderabbitai[bot]]

📝 Walkthrough

Walkthrough

The test test_invalid_max_tokens in the serve negative test suite is updated to expect different error message keywords. The assertion keywords change from "mMaxNewTokens" or "failed" to "max_tokens" or "must be greater than 0", reflecting updated error messaging without altering test flow or logic.

Changes

Cohort / File(s)	Summary
Test assertion update tests/integration/defs/examples/serve/test_serve_negative.py	Updated expected error message keywords in test_invalid_max_tokens from checking for "mMaxNewTokens" or "failed" to checking for "max_tokens" or "must be greater than 0"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single file modified with straightforward test assertion updates
• No logic or control flow changes, only error message keyword expectations updated

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is largely incomplete. While the Test Coverage section lists the relevant test, the Description section explaining what and why is empty, leaving the core purpose of the PR unexplained.	Add a clear explanation in the Description section explaining the issue being fixed and the reason for updating the error message keywords in the test.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows the required format with NVBugs ID and [fix] type, clearly indicating the main change: updating an invalid max_token test.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• [ ] 📝 Generate docstrings

🧪 Generate unit tests (beta)

• [ ] Create PR with unit tests
• [ ] Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a4049fc557a106affad1aa076127f90c5bf2ba2e and 0dc3efc0398a9c9c9f16f728c340b00c2627a539.

📒 Files selected for processing (1)

• tests/integration/defs/examples/serve/test_serve_negative.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: The code developed for TensorRT-LLM should conform to Python 3.8+ Indent Python code with 4 spaces; do not use tabs Always maintain the namespace when importing in Python, even if only one class or function from a module is used (e.g., use from package.subpackage import foo and then foo.SomeClass() instead of from package.subpackage.foo import SomeClass) Python filenames should use snake_case (e.g., some_file.py) Python class names should use PascalCase (e.g., class SomeClass) Python function and method names should use snake_case (e.g., def my_awesome_function():) Python local variable names should use snake_case, with prefix k for variable names that start with a number (e.g., k_99th_percentile = ...) Python global variables should use upper snake_case with prefix G (e.g., G_MY_GLOBAL = ...) Python constants should use upper snake_case (e.g., MY_CONSTANT = ...) Avoid shadowing variables declared in an outer scope in Python Initialize all externally visible members of a Python class in the constructor For Python interfaces that may be used outside a file, prefer docstrings over comments Python comments should be reserved for code within a function, or interfaces that are local to a file Use Google style docstrings for Python classes and functions, which can be parsed by Sphinx Python attributes and variables can be documented inline with type and description (e.g., self.x = 5 followed by """<type>: Description of 'x'""" ) Avoid using reflection in Python when functionality can be easily achieved without reflection When using try-except blocks in Python, limit the except clause to the smallest set of specific errors possible instead of catching all exceptions When using try-except blocks in Python to handle multiple possible variable types (duck-typing), keep the body of the try as small as possible and use the else block to implement the logic

Files:

• tests/integration/defs/examples/serve/test_serve_negative.py

**/*.{cpp,h,cu,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

All TensorRT-LLM Open Source Software code files should contain an NVIDIA copyright header that includes the current year at the top

Files:

• tests/integration/defs/examples/serve/test_serve_negative.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

🔇 Additional comments (1)

tests/integration/defs/examples/serve/test_serve_negative.py (1)

120-121: Updated error-message assertion is correct and better aligned with expected semantics

The new any(keyword in error_msg for keyword in ("max_tokens", "must be greater than 0")) check looks logically sound: it’s case-insensitive (thanks to lower() above) and robust to minor wording differences as long as one of the two substrings appears. This is a clear improvement over the previous mMaxNewTokens/failed match and fits the pattern of the other negative tests.

Since this test relies on specific error text coming back from the server/OpenAI client, please run the relevant pytest target (or your usual test suite) against the backends you care about to confirm the actual error message includes one of these substrings.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tensorrt-cicd]

PR_Github #25671 [ run ] triggered by Bot. Commit: 0dc3efc

[tensorrt-cicd]

PR_Github #25671 [ run ] completed with state SUCCESS. Commit: 0dc3efc /LLM/main/L0_MergeRequest_PR pipeline #19456 completed with status: 'SUCCESS' Pipeline passed with automatic retried tests. Check the rerun report for details.