[TRTLLM-9279][infra] Use flexcache for gh200 nodes since they locate in Austin
Summary by CodeRabbit
-
Chores
- Aligned Kubernetes pod configuration for gh200 nodes to use consistent LLM data volume paths, matching the existing behavior for 6000d nodes.
✏️ Tip: You can customize this high-level summary in your review settings.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
-
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
-
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
-
Test cases are provided for new code paths (see test instructions)
-
Any new dependencies have been scanned for license and vulnerabilities
-
CODEOWNERS updated if ownership changes
-
Documentation updated as needed
-
Update tava architecture diagram if there is a significant design change in PR.
-
The reviewers assigned automatically/manually are appropriate for the PR.
-
[x] Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...
Provide a user friendly way for developers to interact with a Jenkins server.
Run /bot [-h|--help] to print this help message.
See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]
Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.
--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.
--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.
--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.
--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.
--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.
--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.
--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.
--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.
--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.
--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.
--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".
--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.
--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.
For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.
kill
kill
Kill all running builds associated with pull request.
skip
skip --comment COMMENT
Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
reuse-pipeline
reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
📝 Walkthrough
Walkthrough
The change extends Kubernetes pod configuration to treat gh200 node type identically to 6000d when selecting the llm data volume mount. The conditional logic is updated to check if the type contains "6000d" or "gh200", routing both to the Austin-dedicated storage path on server 10.20.162.212.
Changes
| Cohort / File(s) | Summary |
|---|---|
Kubernetes pod volume configuration update jenkins/L0_Test.groovy |
Modified the condition for llmModelVolume selection to treat gh200 node types as equivalent to 6000d, directing both to the Austin-dedicated storage path (10.20.162.212:/vol/scratch26/scratch.trt_llm_data). |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
- Single-file change with a straightforward conditional logic expansion
- Minimal scope: adding "gh200" to an existing type check without altering function signatures
- No API modifications or structural changes
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | ⚠️ Warning | The PR description is incomplete. Only the template is present with no actual content filled in for Description, Test Coverage, or PR Checklist items. | Fill in the Description section explaining the issue and solution, and complete the Test Coverage section listing relevant tests that safeguard these changes. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title accurately describes the main change: configuring gh200 nodes to use flexcache (the Austin/flexcache data volume) based on their Austin location. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✨ Finishing touches
🧪 Generate unit tests (beta)
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
/bot run --stage-list "GH200-PackageSanityCheck-PY312-DLFW, GH200-PackageSanityCheck-PY312-UB2404, GH200-TensorRT-Post-Merge-1"
PR_Github #25552 [ run ] triggered by Bot. Commit: 24fe946
PR_Github #25552 [ run ] completed with state SUCCESS. Commit: 24fe946
/LLM/main/L0_MergeRequest_PR pipeline #19351 (Partly Tested) completed with status: 'SUCCESS'
/bot run --stage-list "GH200-PackageSanityCheck-PY312-DLFW, GH200-PackageSanityCheck-PY312-UB2404, GH200-TensorRT-Post-Merge-1"
PR_Github #25624 [ run ] triggered by Bot. Commit: 24fe946
PR_Github #25624 [ run ] completed with state SUCCESS. Commit: 24fe946
/LLM/main/L0_MergeRequest_PR pipeline #19413 (Partly Tested) completed with status: 'SUCCESS'
/bot run --stage-list "GH200-PackageSanityCheck-PY312-DLFW, GH200-PackageSanityCheck-PY312-UB2404, GH200-TensorRT-Post-Merge-1"
PR_Github #25704 [ run ] triggered by Bot. Commit: 24fe946
PR_Github #25704 [ run ] completed with state SUCCESS. Commit: 24fe946
/LLM/main/L0_MergeRequest_PR pipeline #19486 (Partly Tested) completed with status: 'SUCCESS'
/bot run --stage-list "GH200-PackageSanityCheck-PY312-DLFW, GH200-PackageSanityCheck-PY312-UB2404, GH200-TensorRT-Post-Merge-1" --disable-reuse-test
PR_Github #25835 [ run ] triggered by Bot. Commit: 24fe946
PR_Github #25835 [ run ] completed with state FAILURE. Commit: 24fe946
/bot run --stage-list "GH200-PackageSanityCheck-PY312-DLFW, GH200-PackageSanityCheck-PY312-UB2404, GH200-TensorRT-Post-Merge-1" --disable-reuse-test
PR_Github #25943 [ run ] triggered by Bot. Commit: 24fe946
PR_Github #25943 [ run ] completed with state SUCCESS. Commit: 24fe946
/LLM/main/L0_MergeRequest_PR pipeline #19673 (Partly Tested) completed with status: 'SUCCESS'
/bot skip --comment "Related stages were tested in previous CI"
PR_Github #25982 [ skip ] triggered by Bot. Commit: 48ee557
PR_Github #25982 [ skip ] completed with state SUCCESS. Commit: 48ee557
Skipping testing for commit 48ee557