[https://nvbugs/5670793][fix] Solve trtllm-serve launch_disaggregated issue
Description
This is a cherry-pick from https://github.com/NVIDIA/TensorRT-LLM/pull/9324 to fix the similar issue on main.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
-
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
-
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
-
Test cases are provided for new code paths (see test instructions)
-
Any new dependencies have been scanned for license and vulnerabilities
-
CODEOWNERS updated if ownership changes
-
Documentation updated as needed
-
Update tava architecture diagram if there is a significant design change in PR.
-
The reviewers assigned automatically/manually are appropriate for the PR.
-
[x] Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...
Provide a user friendly way for developers to interact with a Jenkins server.
Run /bot [-h|--help] to print this help message.
See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]
Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.
--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.
--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.
--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.
--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.
--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.
--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.
--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.
--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.
--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.
--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.
--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".
--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.
--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.
For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.
kill
kill
Kill all running builds associated with pull request.
skip
skip --comment COMMENT
Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
reuse-pipeline
reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit
Improvements
- Enhanced the internal communication mechanism for serving processes to improve system stability and efficiency.
- Optimized address allocation strategy for inter-process communication to better manage system resources.
- Streamlined process initialization workflow and updated environment configuration accordingly.
- Reduced overall resource overhead in the serving component while maintaining functionality.
โ๏ธ Tip: You can customize this high-level summary in your review settings.
/bot run
๐ Walkthrough
Walkthrough
Refactors inter-process communication mechanism from TCP ports to IPC addresses. Introduces find_free_ipc_addr() utility function that generates UUID-based IPC addresses in the system temp directory, replacing TCP port allocation used by the disaggregated leader spawning process.
Changes
| Cohort / File(s) | Summary |
|---|---|
IPC Address Utility tensorrt_llm/llmapi/mpi_session.py |
New function find_free_ipc_addr() -> str generates UUID-based IPC address string in system temp directory, returns format ipc://<tempdir>/rpc_<uuid> |
Server Proxy Launch Integration tensorrt_llm/commands/serve.py |
Replaces find_free_port import with find_free_ipc_addr; updates _launch_disaggregated_leader to use IPC address instead of TCP port; sets TLLM_SPAWN_PROXY_PROCESS_IPC_ADDR environment variable to IPC address string instead of tcp://127.0.0.1:<port> format |
Estimated code review effort
๐ฏ 2 (Simple) | โฑ๏ธ ~10 minutes
- The changes are localized and follow a straightforward substitution pattern (TCP port โ IPC address)
- New function is concise with clear responsibility
- Environment variable wiring logic is consistent
- Consider verifying:
- IPC address format compatibility across intended platforms
- Proper cleanup/lifecycle management of temp files used by IPC addresses
- No other code paths expect the old
tcp://format for this environment variable
Pre-merge checks and finishing touches
โ Failed checks (1 warning, 1 inconclusive)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | โ ๏ธ Warning | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | You can run @coderabbitai generate docstrings to improve docstring coverage. |
| Description check | โ Inconclusive | The PR description lacks specific details about what was fixed, why it was necessary, and what tests validate the changes. | Add a substantive explanation of the issue being fixed and list specific tests that validate the changes in the Test Coverage section. |
โ Passed checks (1 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | โ Passed | The title directly addresses the main change: fixing a trtllm-serve launch_disaggregated issue by replacing TCP port allocation with IPC address allocation. |
โจ Finishing touches
- [ ] ๐ Generate docstrings
๐งช Generate unit tests (beta)
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
[!TIP]
๐ Customizable high-level summaries are now available in beta!
You can now customize how CodeRabbit generates the high-level summary in your pull requests โ including its content, structure, tone, and formatting.
- Provide your own instructions using the
high_level_summary_instructionssetting.- Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
- Use
high_level_summary_in_walkthroughto move the summary from the description to the walkthrough section.Example instruction:
"Divide the high-level summary into five sections:
- ๐ Description โ Summarize the main change in 50โ60 words, explaining what was done.
- ๐ References โ List relevant issues, discussions, documentation, or related PRs.
- ๐ฆ Dependencies & Requirements โ Mention any new/updated dependencies, environment variable changes, or configuration updates.
- ๐ Contributor Summary โ Include a Markdown table showing contributions:
| Contributor | Lines Added | Lines Removed | Files Changed |- โ๏ธ Additional Notes โ Add any extra reviewer context. Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
PR_Github #25264 [ run ] triggered by Bot. Commit: ee5a9b8
PR_Github #25264 [ run ] completed with state SUCCESS. Commit: ee5a9b8
/LLM/main/L0_MergeRequest_PR pipeline #19111 completed with status: 'FAILURE'
/bot run --disable-fail-fast
PR_Github #25296 [ run ] triggered by Bot. Commit: ee5a9b8
L0 is failing on deepgemm clone, should be fixed by: https://github.com/NVIDIA/TensorRT-LLM/pull/9349
Need rebase/rerun after that PR...
PR_Github #25296 [ run ] completed with state SUCCESS. Commit: ee5a9b8
/LLM/main/L0_MergeRequest_PR pipeline #19137 completed with status: 'FAILURE'
/bot run
PR_Github #25640 [ run ] triggered by Bot. Commit: 5703c1f
PR_Github #25640 [ run ] completed with state FAILURE. Commit: 5703c1f
LLM/main/L0_MergeRequest_PR #19427 (Blue Ocean) completed with status: ABORTED
/bot run
PR_Github #25815 [ run ] triggered by Bot. Commit: 5703c1f
PR_Github #25815 [ run ] completed with state FAILURE. Commit: 5703c1f
/LLM/main/L0_MergeRequest_PR pipeline #19580 completed with status: 'FAILURE'
/bot run
/bot run
/bot run
PR_Github #25899 [ run ] triggered by Bot. Commit: 5703c1f
/bot run
PR_Github #25918 [ run ] triggered by Bot. Commit: 5703c1f
PR_Github #25899 [ run ] completed with state ABORTED. Commit: 5703c1f
LLM/main/L0_MergeRequest_PR #19640 (Blue Ocean) completed with status: ABORTED
PR_Github #25918 [ run ] completed with state SUCCESS. Commit: 5703c1f
/LLM/main/L0_MergeRequest_PR pipeline #19651 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.