TensorRT-LLM icon indicating copy to clipboard operation
TensorRT-LLM copied to clipboard

[None][fix] Enabled simultaneous support for low-precision combine and MTP.

Open yilin-void opened this issue 3 months ago • 41 comments

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced low-precision combine support detection to optimize performance across different precision formats and configurations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • [x] Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

yilin-void avatar Nov 12 '25 09:11 yilin-void

/bot run

yilin-void avatar Nov 12 '25 09:11 yilin-void

📝 Walkthrough

Walkthrough

A new method is_low_precision_combine_supported() was added to WideEPMoE to encapsulate low-precision combining support logic. A direct property check in the forward path was replaced with this method to conditionally determine if low-precision combining should be used based on quantization configuration.

Changes

Cohort / File(s) Summary
Low-precision combining support abstraction
tensorrt_llm/_torch/modules/fused_moe/fused_moe_wide_ep.py
Added new is_low_precision_combine_supported() method that returns False when disabled, or evaluates quantization flags (fp8_qdq, nvfp4, w4afp8) for DeepEPLowLatency. Replaced direct property check with method call in DeepEPLowLatency forward path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file modification with straightforward logic
  • New method encapsulates configuration checks with clear intent
  • One call site replacement from property access to method invocation
  • No complex interactions or algorithm changes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is completely empty - it contains only the template boilerplate with unfilled sections for Description, Test Coverage, and PR Checklist items. Fill in the Description section explaining what was changed and why, the Test Coverage section listing relevant tests, and complete the PR Checklist to document compliance with project guidelines.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: enabling simultaneous support for low-precision combine and MTP in the WideEPMoE module.
✨ Finishing touches
  • [ ] 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 12 '25 09:11 coderabbitai[bot]

PR_Github #24286 [ run ] triggered by Bot. Commit: d1a8dfc

tensorrt-cicd avatar Nov 12 '25 09:11 tensorrt-cicd

PR_Github #24286 [ run ] completed with state SUCCESS. Commit: d1a8dfc /LLM/main/L0_MergeRequest_PR pipeline #18322 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 12 '25 11:11 tensorrt-cicd

/bot run

yilin-void avatar Nov 13 '25 07:11 yilin-void

PR_Github #24422 [ run ] triggered by Bot. Commit: 67d64fb

tensorrt-cicd avatar Nov 13 '25 07:11 tensorrt-cicd

PR_Github #24422 [ run ] completed with state SUCCESS. Commit: 67d64fb /LLM/main/L0_MergeRequest_PR pipeline #18427 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 13 '25 12:11 tensorrt-cicd

/bot run

yilin-void avatar Nov 14 '25 07:11 yilin-void

PR_Github #24572 [ run ] triggered by Bot. Commit: f13ed1a

tensorrt-cicd avatar Nov 14 '25 07:11 tensorrt-cicd

PR_Github #24572 [ run ] completed with state SUCCESS. Commit: f13ed1a /LLM/main/L0_MergeRequest_PR pipeline #18548 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 14 '25 09:11 tensorrt-cicd

/bot run

yilin-void avatar Nov 17 '25 06:11 yilin-void

PR_Github #24729 [ run ] triggered by Bot. Commit: 5deef0f

tensorrt-cicd avatar Nov 17 '25 06:11 tensorrt-cicd

PR_Github #24729 [ run ] completed with state FAILURE. Commit: 5deef0f

tensorrt-cicd avatar Nov 17 '25 06:11 tensorrt-cicd

/bot run

yilin-void avatar Nov 18 '25 07:11 yilin-void

PR_Github #24870 [ run ] triggered by Bot. Commit: 4ec3da5

tensorrt-cicd avatar Nov 18 '25 07:11 tensorrt-cicd

PR_Github #24870 [ run ] completed with state SUCCESS. Commit: 4ec3da5 /LLM/main/L0_MergeRequest_PR pipeline #18772 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 18 '25 17:11 tensorrt-cicd

/bot run

yilin-void avatar Nov 19 '25 07:11 yilin-void

/bot run

yilin-void avatar Nov 20 '25 02:11 yilin-void

PR_Github #25122 [ run ] triggered by Bot. Commit: 6f6fb6e

tensorrt-cicd avatar Nov 20 '25 02:11 tensorrt-cicd

PR_Github #25122 [ run ] completed with state SUCCESS. Commit: 6f6fb6e /LLM/main/L0_MergeRequest_PR pipeline #18991 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 20 '25 04:11 tensorrt-cicd

/bot run

yilin-void avatar Nov 20 '25 06:11 yilin-void

PR_Github #25162 [ run ] triggered by Bot. Commit: d5ad4ce

tensorrt-cicd avatar Nov 20 '25 07:11 tensorrt-cicd

PR_Github #25162 [ run ] completed with state SUCCESS. Commit: d5ad4ce /LLM/main/L0_MergeRequest_PR pipeline #19024 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 20 '25 09:11 tensorrt-cicd

/bot run --disable-fail-fast

yilin-void avatar Nov 20 '25 09:11 yilin-void

PR_Github #25188 [ run ] triggered by Bot. Commit: a19ef05

tensorrt-cicd avatar Nov 20 '25 10:11 tensorrt-cicd

PR_Github #25188 [ run ] completed with state SUCCESS. Commit: a19ef05 /LLM/main/L0_MergeRequest_PR pipeline #19045 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 20 '25 17:11 tensorrt-cicd

/bot run

yilin-void avatar Nov 21 '25 03:11 yilin-void

PR_Github #25287 [ run ] triggered by Bot. Commit: a19ef05

tensorrt-cicd avatar Nov 21 '25 03:11 tensorrt-cicd

PR_Github #25287 [ run ] completed with state SUCCESS. Commit: a19ef05 /LLM/main/L0_MergeRequest_PR pipeline #19132 completed with status: 'FAILURE'

tensorrt-cicd avatar Nov 21 '25 05:11 tensorrt-cicd

/bot run

yilin-void avatar Nov 21 '25 05:11 yilin-void