TensorRT-LLM icon indicating copy to clipboard operation
TensorRT-LLM copied to clipboard

infra: add pre-commit check to github actions

Open tburt-nv opened this issue 10 months ago • 8 comments

This PR refactors part of the L0 pipeline's release check stage as a python script, and executes it in a GitHub workflow.

In case this new GitHub workflow is unstable, the workflow will not be a blocking/required check for now. We can keep running the same release check inside the L0 pipeline, while also running it in GitHub workflows to provide faster and more direct feedback to developers.

tburt-nv avatar Mar 27 '25 17:03 tburt-nv

/bot skip --comment "only changes the release check"

tburt-nv avatar Mar 27 '25 17:03 tburt-nv

  • example pass: https://github.com/tburt-nv/TensorRT-LLM/actions/runs/14113166128
  • example fail: https://github.com/tburt-nv/TensorRT-LLM/actions/runs/14113202553

tburt-nv avatar Mar 27 '25 17:03 tburt-nv

/bot skip --comment "only changes the release check"

tburt-nv avatar Mar 27 '25 18:03 tburt-nv

PR_Github #658 [ skip ] triggered by Bot

tensorrt-cicd avatar Mar 27 '25 18:03 tensorrt-cicd

PR_Github #658 [ skip ] completed with state SUCCESS Skipping testing for commit eaad386

tensorrt-cicd avatar Mar 27 '25 18:03 tensorrt-cicd

/bot skip --comment "only changes the release check"

tburt-nv avatar Mar 27 '25 18:03 tburt-nv

PR_Github #659 [ skip ] triggered by Bot

tensorrt-cicd avatar Mar 27 '25 18:03 tensorrt-cicd

PR_Github #659 [ skip ] completed with state SUCCESS Skipping testing for commit ab78449

tensorrt-cicd avatar Mar 27 '25 18:03 tensorrt-cicd

Are we sure that the rebase will successfully trigger the action? If everything works as expected, I can try implementing the bot reuse-pipeline with github action (instead of jenkins warpper).

ZhanruiSunCh avatar Mar 30 '25 17:03 ZhanruiSunCh

Are we sure that the rebase will successfully trigger the action? If everything works as expected, I can try implementing the bot reuse-pipeline with github action (instead of jenkins warpper).

@ZhanruiSunCh We discussed about the potential issue of relying on the GitHub action for skipping or reusing the pipeline result. I think the concern is that it would bypass the vulnerability scan.

chzblych avatar Mar 31 '25 00:03 chzblych

Are we sure that the rebase will successfully trigger the action? If everything works as expected, I can try implementing the bot reuse-pipeline with github action (instead of jenkins warpper).

@ZhanruiSunCh We discussed about the potential issue of relying on the GitHub action for skipping or reusing the pipeline result. I think the concern is that it would bypass the vulnerability scan.

I suggest disable the Release Check in Jenkins wrapper to speed up our bot command. (After about a week of making sure that there are no unexpected issues with the github pre-commit action)

ZhanruiSunCh avatar Mar 31 '25 02:03 ZhanruiSunCh

/bot skip --comment "only changes the release check"

tburt-nv avatar Apr 09 '25 23:04 tburt-nv

PR_Github #1660 [ skip ] triggered by Bot

tensorrt-cicd avatar Apr 09 '25 23:04 tensorrt-cicd

PR_Github #1660 [ skip ] completed with state SUCCESS Skipping testing for commit fa19acd

tensorrt-cicd avatar Apr 09 '25 23:04 tensorrt-cicd

/bot skip --comment "only changes the release check"

tburt-nv avatar Apr 10 '25 22:04 tburt-nv

PR_Github #1824 [ skip ] triggered by Bot

tensorrt-cicd avatar Apr 10 '25 22:04 tensorrt-cicd

PR_Github #1824 [ skip ] completed with state SUCCESS Skipping testing for commit c93e8cf

tensorrt-cicd avatar Apr 10 '25 22:04 tensorrt-cicd