NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Fix py3.11 dataclasses issue

Open MedAymenF opened this issue 1 year ago • 1 comments

What does this PR do ?

Fixes #9419.

Collection: [ASR]

Changelog

  • Fix dataclasses in examples/asr/transcribe_speech.py.
  • Fix dataclasses in examples/asr/speech_to_text_eval.py.

Before your PR is "Ready for review"

Pre checks:

  • [x] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [x] Bugfix
  • [ ] Documentation

Additional Information

  • Related to #7166.

MedAymenF avatar Jun 11 '24 17:06 MedAymenF

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Jun 27 '24 01:06 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Jul 04 '24 01:07 github-actions[bot]

Could you fix the formatting checks?

pzelasko avatar Aug 03 '24 14:08 pzelasko

Could you fix the formatting checks?

Formatting checks are passing now (after I synced my fork).

MedAymenF avatar Aug 06 '24 01:08 MedAymenF

We're seeing some CI instability so the tests are taking longer than ususal. I merged main and re-triggered the failing tests (they don't seem related to your changes). Will keep monitoring this PR until it's all green.

pzelasko avatar Aug 07 '24 13:08 pzelasko