NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Wrap all fp8 extra states in LocalNonpersistentObject

Open jbaczek opened this issue 1 year ago • 1 comments

What does this PR do ?

This PR generalizes FP8 extra state wrapping for all tensors.

Collection: nlp

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [x] Bugfix
  • [ ] Documentation

jbaczek avatar Jun 10 '24 09:06 jbaczek

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Jun 28 '24 01:06 github-actions[bot]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Jul 23 '24 01:07 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Jul 30 '24 01:07 github-actions[bot]