NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Audio model collection

Open anteju opened this issue 1 year ago • 2 comments

What does this PR do ?

This PR moves audio-specific models to a separate collection.

Collection: ASR, audio

Changelog

  • Moved audio-specific models from ASR collection into a separate audio collection
  • Moved corresponding tests
  • Updated scripts and tutorials

Usage

n/a

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [x] Make sure you read and followed Contributor guidelines
  • [x] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [x] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

anteju avatar May 21 '24 02:05 anteju

LGTM besides a couple of little nitpicks

racoiaws avatar Jun 17 '24 16:06 racoiaws

LGTM overall. We could also rename https://github.com/anteju/NeMo/blob/pr/audio-collection/examples/audio/speech_enhancement.py to https://github.com/anteju/NeMo/blob/pr/audio-collection/examples/audio/audio_to_audio_train.py to align with rest of the filenames in the examples folder

Done.

anteju avatar Jun 29 '24 23:06 anteju