NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

ci: Multi-tenancy for tests and garbage collection

Open ko3n1g opened this issue 1 year ago • 2 comments

What does this PR do ?

More robust CI pipeline by creating isolated directories for job-outputs.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

ko3n1g avatar May 13 '24 15:05 ko3n1g

Hey @pablo-garay , this is an proposal how we could make our CI pipeline a bit more stable. We should/could isolate folders that are being written to, and garbage-collect them by if: always() steps.

The only caveat I can see is that templating our tests might become a little bit more tricky. But I don't think it would be a blocker. See #9177 for reference

ko3n1g avatar May 13 '24 17:05 ko3n1g

Fantastic proposal

We need this for all tests whose name start with prefix: L2_Community_LLM_Checkpoints_tests_ Could you please kindly make the proposed change & add for the other tests? :)

pablo-garay avatar May 13 '24 18:05 pablo-garay