NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Fix nemo_llama_to_hf conversion

Open tdene opened this issue 2 years ago • 2 comments

What does this PR do ?

Fix convert_nemo_llama_to_hf.py:

  • Correctly account for megatron_amp_O2 flag
  • Save HF model with correct precision
  • Transfer over the NeMo tokenizer, instead of using the possibly-incompatible default tokenizer
  • Make sure to save fast version of tokenizer
  • Resize the model's embedding tensor to match the new tokenizer's vocab
  • Correct a typo in how-to-use example

PR Type:

  • [ ] New Feature
  • [x] Bugfix
  • [ ] Documentation

Who can review?

@ericharper

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

tdene avatar Dec 08 '23 09:12 tdene

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Dec 30 '23 01:12 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Jan 06 '24 01:01 github-actions[bot]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

github-actions[bot] avatar Feb 25 '24 01:02 github-actions[bot]

jenkins

cuichenx avatar Feb 29 '24 05:02 cuichenx