NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Pytorch lightning required but not installed for text_normalization

Open f4hy opened this issue 3 years ago • 0 comments

Describe the bug

Installing nemo_toolkit[nemo_text_processing] does not bring in pytorch_lightning but then

from nemo_text_processing.text_normalization import normalize

errors as pytorch_lightning is required to import

Steps/Code to reproduce bug

  1. on a fresh venv, install nemo_toolkit[nemo_text_processing]
  2. run from nemo_text_processing.text_normalization import normalize
  3. See error

Expected behavior

If text processing requires pytorch_lightning it should be installed as a requirement

f4hy avatar Jul 22 '22 15:07 f4hy

from nemo_text_processing.text_normalization import normalize should not require pytorch lightning. I was not able to reproduce this error.

I ran python -m pip install git+https://github.com/NVIDIA/NeMo.git@main#egg=nemo_toolkit[nemo_text_processing] then installed pynini with pip, and then ran from nemo_text_processing.text_normalization import normalize

yzhang123 avatar Aug 10 '22 16:08 yzhang123

closing due to inactivity

yzhang123 avatar Aug 25 '22 14:08 yzhang123