NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

fixes invalid_ids error on Megatron decode function

Open Davood-M opened this issue 3 years ago • 1 comments

Signed-off-by: David Mosallanezhad [email protected]

What does this PR do ?

fixes invalid_ids error on Megatron decode function by changing invalid tokens to

Collection: NLP

Changelog

  • small bug fix

Before your PR is "Ready for review"

Pre checks:

  • [X] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [X] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Davood-M avatar Jun 15 '22 05:06 Davood-M

@Davood-M @MaximumEntropy PR https://github.com/NVIDIA/NeMo/pull/4210 is fixing this issue.

michalivne avatar Jun 17 '22 01:06 michalivne

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Oct 07 '22 02:10 github-actions[bot]