NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Refactor `FilterbankFeatures` masking to use `make_seq_mask_like` utility

Open SangwonSUH opened this issue 3 months ago • 0 comments

What does this PR do ?

Don't reinvent the wheel

Refactor FilterbankFeatures.forward

Collection: [asr]

Changelog

  • Refactor FilterbankFeatures masking to use make_seq_mask_like

Before your PR is "Ready for review"

Pre checks:

  • [x] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [x] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Requesting review from ASR members: @titu1994, @redoctopus, @jbalam-nv, or @okuchaiev

Additional Information

  • jit.trace-ing of FilterbankFeatures hardcoded to cuda:0. Utilizing make_seq_mask_like solves this issue.

SangwonSUH avatar Nov 19 '25 13:11 SangwonSUH