NeMo
NeMo copied to clipboard
Refactor `FilterbankFeatures` masking to use `make_seq_mask_like` utility
What does this PR do ?
Don't reinvent the wheel
Refactor FilterbankFeatures.forward
Collection: [asr]
Changelog
- Refactor
FilterbankFeaturesmasking to usemake_seq_mask_like
Before your PR is "Ready for review"
Pre checks:
- [x] Make sure you read and followed Contributor guidelines
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
PR Type:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Requesting review from ASR members: @titu1994, @redoctopus, @jbalam-nv, or @okuchaiev
Additional Information
-
jit.trace-ing ofFilterbankFeatureshardcoded tocuda:0. Utilizingmake_seq_mask_likesolves this issue.