NeMo icon indicating copy to clipboard operation
NeMo copied to clipboard

Support to use te-dpa for sd model.

Open Dido0o0 opened this issue 1 year ago • 2 comments

What does this PR do ?

This PR is to enable the Stable Diffusion model can take use of DotProductAttention in addition to FlashAttention. To enable TE-DotProductAttention, users can set config use_te_dpa to be True.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [ ] Make sure you read and followed Contributor guidelines
  • [ ] Did you write any new necessary tests?
  • [ ] Did you add or update any necessary documentation?
  • [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [ ] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [ ] New Feature
  • [ ] Bugfix
  • [ ] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed. Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Dido0o0 avatar Aug 16 '24 07:08 Dido0o0

Please rebase against upstream/main to allow us running the CI

ko3n1g avatar Aug 23 '24 09:08 ko3n1g

Could you please rebase the branch to remove irrelevant changes first?

Victor49152 avatar Aug 23 '24 17:08 Victor49152

Dido is busy with other stuff, I made some modification on top of her changes. Here is the new PR: https://github.com/NVIDIA/NeMo/pull/10288, please review there, thanks! Closing this one.

alpha0422 avatar Aug 28 '24 15:08 alpha0422