NeMo-Guardrails icon indicating copy to clipboard operation
NeMo-Guardrails copied to clipboard

fix: move relevant chunks before current conversations

Open Pouyanpi opened this issue 1 year ago • 1 comments

Otherwise the bot will generate based on the relevant chunks only.

Pouyanpi avatar Sep 24 '24 15:09 Pouyanpi

@drazvan would you have a look? Please try out abc_v2 on develop branch to see the issue. Can it be included in the patch release?

Pouyanpi avatar Sep 30 '24 12:09 Pouyanpi

I think we need to better test the introduced change in #745. Changing the prompts like that can result in unexpected behavior. E.g. I would suggest removing the markdown notation. Also, we need to take a look at the prompt templates for the GPT 4 and Llama 3 models.

schuellc-nvidia avatar Oct 11 '24 16:10 schuellc-nvidia

@schuellc-nvidia, are we good to merge this PR considering #809 ?

Pouyanpi avatar Oct 17 '24 15:10 Pouyanpi