DALI icon indicating copy to clipboard operation
DALI copied to clipboard
verified publisher icon NVIDIA

Improve performance of experimental.resize

Open banasraf opened this issue 1 year ago • 12 comments

Category:

Refactoring

Description:

This PR improves experimental.resize operator to reduce the CPU overhead of the operator. It contains the following improvements (from most to least significant):

  • using two workspace objects for the CV-CUDA op to get rid of synchronising between minibatches
  • using custom allocator (taking memory from scratchpad) for the input/output TensorBatches
  • improved method for creating input/output TensorBatch objects: moving all common parts out of the loop
  • removed auxiliary TensorLists in favour of using the original i/os directly with PushFramesToBatch method

Additional information:

Affected modules and functionalities:

experimental.resize, nvcvop.h/cc

Key points relevant for the review:

Tests:

  • [x] Existing tests apply
  • [ ] New tests added
    • [ ] Python tests
    • [ ] GTests
    • [ ] Benchmark
    • [ ] Other
  • [ ] N/A

Checklist

Documentation

  • [x] Existing documentation applies
  • [ ] Documentation updated
    • [ ] Docstring
    • [ ] Doxygen
    • [ ] RST
    • [ ] Jupyter
    • [ ] Other
  • [ ] N/A

DALI team only

Requirements

  • [ ] Implements new requirements
  • [ ] Affects existing requirements
  • [ ] N/A

REQ IDs: N/A

JIRA TASK: N/A

banasraf avatar Oct 07 '24 12:10 banasraf

!build

banasraf avatar Oct 07 '24 12:10 banasraf

CI MESSAGE: [19099938]: BUILD STARTED

dali-automaton avatar Oct 07 '24 12:10 dali-automaton

CI MESSAGE: [19099938]: BUILD FAILED

dali-automaton avatar Oct 07 '24 14:10 dali-automaton

!build

banasraf avatar Oct 29 '24 15:10 banasraf

CI MESSAGE: [19870509]: BUILD FAILED

dali-automaton avatar Oct 29 '24 15:10 dali-automaton

!build

banasraf avatar Oct 29 '24 16:10 banasraf

CI MESSAGE: [19871581]: BUILD STARTED

dali-automaton avatar Oct 29 '24 16:10 dali-automaton

CI MESSAGE: [19871581]: BUILD PASSED

dali-automaton avatar Oct 29 '24 18:10 dali-automaton

!build

banasraf avatar Jun 12 '25 09:06 banasraf

CI MESSAGE: [29950877]: BUILD FAILED

dali-automaton avatar Jun 12 '25 09:06 dali-automaton

CI MESSAGE: [29950877]: BUILD STARTED

dali-automaton avatar Jun 12 '25 09:06 dali-automaton

CI MESSAGE: [29950877]: BUILD PASSED

dali-automaton avatar Jun 12 '25 15:06 dali-automaton

!build

banasraf avatar Jul 03 '25 09:07 banasraf

CI MESSAGE: [31003228]: BUILD STARTED

dali-automaton avatar Jul 03 '25 09:07 dali-automaton

CI MESSAGE: [31003228]: BUILD FAILED

dali-automaton avatar Jul 03 '25 09:07 dali-automaton

!build

banasraf avatar Jul 03 '25 09:07 banasraf

CI MESSAGE: [31005410]: BUILD STARTED

dali-automaton avatar Jul 03 '25 09:07 dali-automaton

CI MESSAGE: [31005410]: BUILD FAILED

dali-automaton avatar Jul 03 '25 15:07 dali-automaton

!build

banasraf avatar Jul 28 '25 09:07 banasraf

CI MESSAGE: [32390728]: BUILD STARTED

dali-automaton avatar Jul 28 '25 09:07 dali-automaton

CI MESSAGE: [32390728]: BUILD FAILED

dali-automaton avatar Jul 28 '25 10:07 dali-automaton

CI MESSAGE: [32390728]: BUILD PASSED

dali-automaton avatar Jul 30 '25 14:07 dali-automaton

!build

banasraf avatar Aug 07 '25 09:08 banasraf

CI MESSAGE: [32945037]: BUILD STARTED

dali-automaton avatar Aug 07 '25 09:08 dali-automaton

CI MESSAGE: [32945037]: BUILD FAILED

dali-automaton avatar Aug 07 '25 09:08 dali-automaton

!build

banasraf avatar Aug 07 '25 10:08 banasraf

CI MESSAGE: [32949058]: BUILD STARTED

dali-automaton avatar Aug 07 '25 10:08 dali-automaton

CI MESSAGE: [32949058]: BUILD FAILED

dali-automaton avatar Aug 07 '25 12:08 dali-automaton

CI MESSAGE: [32949058]: BUILD PASSED

dali-automaton avatar Aug 08 '25 09:08 dali-automaton

!build

banasraf avatar Aug 08 '25 15:08 banasraf