isaac_ros_pose_estimation icon indicating copy to clipboard operation
isaac_ros_pose_estimation copied to clipboard
verified publisher icon NVIDIA-ISAAC-ROS

Convert degrees to radians for inplane rotations

Open STREM-hexagon opened this issue 5 months ago • 1 comments

The numbers for creating the inplane rotations are clearly given in degrees, but the code for creating the rotation matrix expects radians. This PR adds a conversion to fix this. This fixes https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_pose_estimation/issues/73, but differs from the solution proposed in the issue by making the conversion outside of the loop for efficiency.

STREM-hexagon avatar Aug 07 '25 11:08 STREM-hexagon

Thanks for catching and fixing this, it looks good to me. We will include this fix in the next patch for release-3.2.

yuanknv avatar Aug 13 '25 23:08 yuanknv