CodeIgniter-Subqueries icon indicating copy to clipboard operation
CodeIgniter-Subqueries copied to clipboard

Indicate return types

Open luckydonald opened this issue 7 years ago • 2 comments

The current version

/**
 * start_union - Creates a new database object to be used for unions
 *
 * @return A new database object to use for a union query
 */
function start_union(){
	$this->unions++;
	return $this->start_subquery('');
}

Causes image Because the A from "A new database..." is the first argument here.

Instead the first word should be the returned type:

/**
 * @return CI_Loader A new database object to use for a union query
 */

luckydonald avatar Jul 20 '18 20:07 luckydonald

Should I prepare a PR?

luckydonald avatar Jul 20 '18 20:07 luckydonald

Yeah, if you can fix this, I can merge in your changes. It looks like the phpdoc comments just need to be updated correctly.

NTICompass avatar Jul 20 '18 21:07 NTICompass