NREL
Return REopt errors warns back to user
Please check if the PR fulfills these requirements
- [ ] CHANGELOG.md is updated
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
What is the current behavior?
(You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information:
@rathod-b this would be great to merge soon. What's your timeline for responding to @hdunham's review comments?
@Bill-Becker @hdunham This PR should be ready for review next week (I just need to add documentation to REopt Wiki). Note that we would need to merge https://github.com/NREL/REopt.jl/pull/118 before this can be merged into Develop.
Some CHP tests are failing most likely because REopt TOML files point to REopt.jl's error-msgs branch. When that branch is merged into develop, failing tests should pass.
@rathod-b looks like the chp_defaults test is not passing because the stuff starting here: https://github.com/NREL/REopt_API/blob/69b392c7d767ab8e72feb23a252612f14fcb3e04/julia_src/http.jl#L83 did not get merged when you merged develop.
@rathod-b I fixed a couple of accidental auto-merge deletion issues, and all the tests are passing now. I would comb through everything to make sure there are not more unintended deletions or other merge issues which may not be causing any issues with tests. Otherwise, looks good. Great work on this!
@rathod-b The error-messages branch PR has been merged into master and published. Can you update the REopt.jl package in this branch?
@rathod-b The error-messages branch PR has been merged into master and published. Can you update the REopt.jl package in this branch?
Yes, i can. Will let you know when this is updated, re-tested, and validated.