ChangeBuildingLocation assigns full climate zone document designations to OS:ClimateZones 'Value' field

[eringold]

Current options for ASHRAE 'climate_zone' arguments in ChangeBuildingLocation measure specify ASHRAE 169-2013: https://github.com/NREL/ComStock/blob/a541f15d27206f4e23d56be53ef8b7e154edda9e/resources/measures/ChangeBuildingLocation/measure.rb#L102-L118

But when the measure sets the climate zone info in the model, it tries to remove the string 'ASHRAE 169-2006-' from the climate zone argument: https://github.com/NREL/ComStock/blob/a541f15d27206f4e23d56be53ef8b7e154edda9e/resources/measures/ChangeBuildingLocation/measure.rb#L357

This results in the 'value' field of the OS:ClimateZones object populated with the whole climate zone string:

where it should just be the designation: https://github.com/NREL/OpenStudio/blob/05c60768c1e1057083ce644d49711f7377f8ce1e/src/model/ClimateZones.hpp#L42-L44

I think the only implication of the value field containing the whole cz string is that any measure that uses the value has to strip out the extra characters, as in 'set nist infiltration coefficients': https://github.com/NREL/ComStock/blob/a541f15d27206f4e23d56be53ef8b7e154edda9e/resources/measures/set_nist_infiltration_correlations/measure.rb#L524-L528

But check if there's anything in postprocessing that might be affected by this.