ComStock
ComStock copied to clipboard
Ccaradon/sdr 2025 r4 fix timeseries plots
Pull request overview
Fixes timeseries plotting capabilities for AMI comparisons and upgrade measure comparisons. Includes a new query class that accounts for sample-specific weights from the prior workflow of using BuildStockQuery with building-type-specific weights.
Pull Request Author
This pull request makes changes to (select all the apply):
- [ ] Documentation
- [ ] Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
- [ ] Sampling
- [ ] Workflow Measures
- [ ] Upgrade Measures
- [ ] Reporting Measures
- [ ] Postprocessing
Pull Request Author Checklist:
- [ ] Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
- [ ] Added or edited tests for measures that adequately cover anticipated cases
- [ ] New or changed register values reflected in
comstock_column_definitions.csv - [ ] Both
options_lookup.tsvfiles updated - [ ] New measure tests add to to
test/reporting_measure_tests.txt,test/workflow_measure_tests.txt, ortest/upgrade_measure_tests.txt - [ ] Added 'See ComStock License' language to first two lines of each code file
- [ ] Run rubocop and check log
- [ ] Updated measure .xml(s)
- [ ] Ran 10k+ test run and checked failure rate to make sure no new errors were introduced
- [ ] Measure documentation written or updated
- [ ] ComStock documentation written or updated
- [ ] Change document written and assigned to a reviewer
- [ ] Changes reflected in example
.ymlfiles andREADME.mdfiles
Pull Request Reviewer Checklist:
- [ ] Perform a code review on GitHub
- [ ] All changes have been implemented: data, methods, tests, documentation
- [ ] If fixing a defect, verify by running main branch to reproduce the defect and the PR branch to verify the fix
- [ ] Measure tests written and adequately cover anticipated cases
- [ ] Run measure tests and ensure they pass
- [ ] New measure tests add to to
test/reporting_measure_tests.txt,test/workflow_measure_tests.txt, ortest/upgrade_measure_tests.txt - [ ] Ensured code files contain License reference
- [ ] Run rubocop and check log
- [ ] Measure .xml updated
- [ ] CI status: all tests pass
- [ ] ComStock documentation adequately describes the new assumptions
- [ ] Reviewed change documentation, results differences are reasonable, and no new errors introduced
- [ ] Author has addressed comments in change documentation
- [ ]
.ymlandREADME.mdfiles updated
ComStock Licensing Language - Add to Beginning of Each Code File
# ComStock™, Copyright (c) 2025 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.