BuildingMOTIF icon indicating copy to clipboard operation
BuildingMOTIF copied to clipboard

Update 223P to public advisory review version

Open gtfierro opened this issue 1 year ago • 1 comments

gtfierro avatar Mar 20 '24 01:03 gtfierro

Feedback from NIST:

  • Model contains HeatRecoveryCoil - not recognized
  • Missing label warnings
  • ConnectionPoint mapsTo warnings
  • There's a system needing at least 2 members
  • System does not have s223:contains defined
  • There's a sensor that's contained but not attached to Connection/ConnectionPoint

gtfierro avatar Mar 25 '24 18:03 gtfierro

TODO:

  • move library tests to a new tests/libraries folder
  • have 1 Pytest Class per library. Inside the setup_class method, create a new bmotif instance, load the library, and figure out all the templates
  • this should also parameterize a class-local fixture which parameterizes a site-specific tesT_template method. This reuses the library and bmotif state established in the setup_class method

gtfierro avatar Jun 26 '24 20:06 gtfierro

@TShapinsky I think this is finally ready for review!

gtfierro avatar Jul 05 '24 15:07 gtfierro

Looks good, @gtfierro. I have a couple more comments, but hopefully that should be it.

TShapinsky avatar Jul 05 '24 18:07 TShapinsky