BuildingMOTIF
BuildingMOTIF copied to clipboard
Update 223P to public advisory review version
Feedback from NIST:
- Model contains HeatRecoveryCoil - not recognized
- Missing label warnings
- ConnectionPoint mapsTo warnings
- There's a system needing at least 2 members
- System does not have s223:contains defined
- There's a sensor that's contained but not attached to Connection/ConnectionPoint
TODO:
- move library tests to a new
tests/librariesfolder - have 1 Pytest Class per library. Inside the
setup_classmethod, create a new bmotif instance, load the library, and figure out all the templates - this should also parameterize a class-local fixture which parameterizes a site-specific
tesT_templatemethod. This reuses the library and bmotif state established in thesetup_classmethod
@TShapinsky I think this is finally ready for review!
Looks good, @gtfierro. I have a couple more comments, but hopefully that should be it.