Make the photon a downloadable resource
This PR addresses #2214
Hi @scarlehoff , can you please start having a look? I'm pretty sure this needs to be tweaked a bit more, but it's a good starting point. I tried using a local photon set, generated using the new script fiatlux_exec.py, to check if I implemented the loading part correctly, and it works. Some major things are still missing:
- A proper remote folder, where the photon can be downloaded. Note that the code in
download_photonQEDis commented out because I'm waiting for instructions on this respect. - Tests need to be updated. But I'd prefer to wait until a final version of this PR.
A proper remote folder, where the photon can be downloaded. Note that the code in download_photonQED is commented out because I'm waiting for instructions on this respect.
Let's use the Milan server for this for now: /home/nnpdf/WEB/photons this is a sibling of e.g. /home/nnpdf/WEB/hyperscans
I think the parallelization is ok as well (provided it runs, I didn't test it).
I think for now (before testing the download online) just make it so the download is a copy from some folder in your computer to the share folder. If that works the download from the server is a technicality and will work just the same.
I think this will already ease quite a bit the QED fits (e.g., all the positivity checks that are being done now could be done with QED for free thanks to this for the price of one single computation of the photon!)
Please, have a look at this training report (link). In the new fit, I downloaded the photon previously computed with the script fiatlux-exec.
One thing that is left is whether we want to move fiatlux-exec into vp-setupfit fit. In general, we need to agree on how we want to compute and upload the photon PDF.