fix sorting of postfit symlinks
Currently postfit symlinks are sorted only based on the first number of the replica folder eg
1, 10, 11, 12, 13, ..., 2, 20, ...
This PR fixes this st the order is sorted
Note that postfit writes a FromMCReplica, which allows you to know which fitted replica a given PDF replica corresponds to. Of course if you don't like the sorting it can be changed, but practically there is no problem with the current ordering.
Note that postfit writes a
FromMCReplica, which allows you to know which fitted replica a given PDF replica corresponds to. Of course if you don't like the sorting it can be changed, but practically there is no problem with the current ordering.
Hi @RoyStegeman, I agree that practically there is no problem with that. In fact I did not label it as a bug.
However, there is a sorted operation done in the code and it is confusing since it does not sort properly.
Is there an advantage? The replicas and members are not expected to be aligned anyway.
The only advantage / need for it is when replicas need to be ordered as they are, for instance, in a Hessian set. But there is nothing in NNPDF / validphys, I think, for which this would be needed.