nnpdf New Multi-Closure test analysis module

addresses #2159

The main goals of this PR are:

multiclosure analysis modules are reviewed and rewritten based on the new findings of the inconsistent closure tests paper.
All functions / helpers used for computation of bias with exp. covmat are removed.
All functions / helpers for computation of variance are removed.
Removed vp-comparefits --closure

Feb 04 '25 15:02 comane

@jacoterh will you review this one?

Apr 08 '25 07:04 scarlehoff

Yes, sorry about the delay - I will take a closer look

Apr 08 '25 14:04 jacoterh

Hi @comane, many thanks for this. Would you mind updating the corresponding documentation on the website as well? Specifically, could you make sure what is written on https://github.com/NNPDF/nnpdf/blob/3556b8f13f8284a6ba06fd82f1b0541080672370/doc/sphinx/source/tutorials/closureestimators.rst is still up to date? For example, the --closure option was removed, while the documentation mentions it.

Apr 09 '25 10:04 jacoterh

What is the status of this one?

Apr 28 '25 11:04 scarlehoff

What is the status of this one?

I wanted #2258 to be merged first. Now will have a final look at it. However, it should be basically ready to go.

Apr 28 '25 14:04 comane

What is the status of this one?

What is the status of this one?

Oct 07 '25 07:10 scarlehoff