nnpdf icon indicating copy to clipboard operation
nnpdf copied to clipboard

Update to new commondata names in docs, examples and tests

Open RoyStegeman opened this issue 1 year ago • 9 comments

  • [x] Remove reproduce 4.0
  • [x] Update runcards in vp
  • [x] Update runcards in n3fit
  • [x] Update docstrings in n3fit
  • [ ] Update docstrings in vp
  • [x] Update tests in vp
  • [x] Update tests in n3fit
  • [ ] Update docs

RoyStegeman avatar Mar 01 '24 10:03 RoyStegeman

Dear @RoyStegeman, @peterkrack and I are willing to help change the names in this PR. I have a question regarding the docstrings in vp. Where do we exactly specify the dataset names?

enocera avatar May 23 '24 14:05 enocera

Thanks a lot! In the docstrings we regularly provide examples of how a function can be used (through the API). I put it separately because while the names in the tests can be updated and as long as the tests pass afterwords it's fine, the doctring examples may need to be tested. Feel free to do them simultaneously, but to me it made sense to separate them.

RoyStegeman avatar May 23 '24 14:05 RoyStegeman

Sorry this is not complete, if I just do a bruteforce search for the old names I still find plenty

RoyStegeman avatar Jul 31 '24 15:07 RoyStegeman

Really? My bad, then. I thought I had fixed them all.

enocera avatar Jul 31 '24 15:07 enocera

No worries, it doesn't look like there are many left, but it's a bit early to close this

RoyStegeman avatar Jul 31 '24 15:07 RoyStegeman

I'll have a second pass, then.

enocera avatar Jul 31 '24 15:07 enocera

Thanks, though if you don't have the time I'm sure we can include it in the list of tasks to be delegated in Morimondo

RoyStegeman avatar Jul 31 '24 15:07 RoyStegeman

list of tasks to be delegated in Morimondo

Perhaps you meant the illustrious list of missions that will be assigned to honoured researchers in Morimondo.

scarlehoff avatar Jul 31 '24 15:07 scarlehoff

Yes that's what I meant to type. Damn autocorrect!

RoyStegeman avatar Jul 31 '24 15:07 RoyStegeman